Merged
Conversation
radeva
commented
Feb 19, 2018
radeva
commented
- add some info about typings generation for Android and iOS
- add Contributing.d
- add PR template
- fix tests for Win
added 2 commits
February 16, 2018 17:00
Add some instructions for typings generation for iOS and Android native libraries
- update readme to add some info about community slack and forums - add Contributing.md - add PR template - fix tests for windows - remove tests for npm link
ghost
assigned
tbozhikov
approved these changes
Feb 23, 2018
| - Rebase your changes to the latest master: `git pull --rebase upstream master`. | ||
| - Ensure all unit test are green. How? | ||
| - Go to `seed-tests` | ||
| - Delete `seed-copy` if existing |
There was a problem hiding this comment.
I think we delete this folder in the tests (upon test start) via rimraf.sync() call, so this step might be redundant here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.